-
Notifications
You must be signed in to change notification settings - Fork 372
chore(localizations): Added missing pt-BR
translations
#6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8d81a8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@fell-lucas is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughA new changeset (.changeset/forty-bottles-accept.md) was added and the Brazilian Portuguese localization file (packages/localizations/src/pt-BR.ts) was updated. The pt-BR export now includes many completed translation strings across API keys, badges, commerce, subscriptions, sign-in/sign-up flows, passkeys, Web3 wallets, error messages, organization/user profiles, dates, organization switcher, and other UI labels. A new top-level property taskChooseOrganization was added to the ptBR object containing signOut, createOrganization, and chooseOrganization entries. No API or exported type declarations were changed. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (9)**/*.{js,jsx,ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Files:
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Files:
packages/**/*.{ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Files:
packages/**/*.{ts,tsx,d.ts}📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Files:
**/*.{ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Files:
packages/localizations/**/*📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Files:
**/*.{js,ts,tsx,jsx}📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Files:
**/*⚙️ CodeRabbit Configuration File
Files:
**/localizations/**/*.ts⚙️ CodeRabbit Configuration File
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🔭 Outside diff range comments (1)
packages/localizations/src/pt-BR.ts (1)
1058-1058
: Untranslated string: “Add” should be localizedThis is visible UI text; translate to pt-BR.
- formButtonPrimary__add: 'Add', + formButtonPrimary__add: 'Adicionar',
🧹 Nitpick comments (2)
packages/localizations/src/pt-BR.ts (1)
1-1286
: Tests and lintingNo tests were added. Consider adding a key-coverage and placeholder-parity test (like the script above) to prevent regressions. Also ensure Prettier/ESLint pass for this file.
You can adapt the script above into a unit test to enforce parity with en-US.
.changeset/forty-bottles-accept.md (1)
1-6
: Changeset looks correct; minor copy nitConsider using hyphenated locale and imperative mood.
-added missing ptBR translations +add missing pt-BR translations
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/forty-bottles-accept.md
(1 hunks)packages/localizations/src/pt-BR.ts
(17 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
.changeset/**
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/forty-bottles-accept.md
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}
: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/localizations/src/pt-BR.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/pt-BR.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/pt-BR.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/localizations/src/pt-BR.ts
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}
: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidany
type - preferunknown
when type is uncertain, then narrow with type guards
Useinterface
for object shapes that might be extended
Usetype
for unions, primitives, and computed types
Preferreadonly
properties for immutable data structures
Useprivate
for internal implementation details
Useprotected
for inheritance hierarchies
Usepublic
explicitly for clarity in public APIs
Preferreadonly
for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertions
for literal types:as const
Usesatisfies
operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noany
types without justification
Proper error handling with typed errors
Consistent use ofreadonly
for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/localizations/src/pt-BR.ts
packages/localizations/**/*
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Localization files must be placed in 'packages/localizations/'.
Files:
packages/localizations/src/pt-BR.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/localizations/src/pt-BR.ts
**/*
⚙️ CodeRabbit Configuration File
If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.
Files:
packages/localizations/src/pt-BR.ts
**/localizations/**/*.ts
⚙️ CodeRabbit Configuration File
**/localizations/**/*.ts
: Review the changes to localization files with the following guidelines:
- Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
- Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
- Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
- Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
- Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
- Ensure that all keys are unique and that there are no duplicate or conflicting entries.
- If you notice missing translations for new keys, flag them for completion.
Files:
packages/localizations/src/pt-BR.ts
🔇 Additional comments (6)
packages/localizations/src/pt-BR.ts (6)
17-36
: New organization chooser translations read wellWording is clear and semi-formal; placeholders look correct. No issues found.
281-283
: API Keys titles/nav look consistentThe additions for API Keys in org and user sections are consistent and clear. No issues found.
Also applies to: 403-409, 931-933, 1116-1122
721-723
: Sign-in combined subtitle is friendly and appropriateTone and phrasing look good for pt-BR. No issues found.
822-823
: Social provider label (many-in-view) looks correctShowing only the provider name matches expected pattern. No issues found.
829-845
: Error messages look accurate and safeWording is clear, formal, and non-offensive. Placeholders appear correct.
Also applies to: 861-862, 882-883
1-1286
: Confirm translation key and placeholder parity
I attempted to run the comparison script, but it didn’t emit any results. Please manually verify that:
- pt-BR covers every key defined in en-US (no missing or extra entries)
- Each {{…}} placeholder in pt-BR exactly matches its counterpart in en-US (no missing or stray variables)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (3)
packages/localizations/src/pt-BR.ts (3)
57-64
: Resolved ambiguity for minutes vs months — good fixUsing “min” for minutes and “mês(es)” for months follows pt-BR conventions and removes ambiguity.
1249-1251
: Likely wrong action label: should set wallet as primary, not “Conectar”For consistency with other “detailsAction__nonPrimary” entries (e.g., email/phone), this action should set the wallet as primary.
Apply this diff:
- detailsAction__nonPrimary: 'Conectar carteira', + detailsAction__nonPrimary: 'Definir como principal',
218-221
: Placeholder should use “chave de API”, not “chave secreta”One remaining inconsistency with the preferred terminology.
Apply this diff:
- formFieldInputPlaceholder__apiKeyName: 'Digite o nome da sua chave secreta', + formFieldInputPlaceholder__apiKeyName: 'Digite o nome da sua chave de API',Optionally also align creation button for clarity:
- formButtonPrimary__add: 'Criar chave', + formButtonPrimary__add: 'Criar chave de API',
🧹 Nitpick comments (2)
packages/localizations/src/pt-BR.ts (2)
38-40
: Terminology consistency: explicitly say “chave de API” in actionsTo match other occurrences (titles, navbar, placeholders), prefer “chave de API” over generic “chave”.
Apply this diff:
- action__add: 'Adicionar nova chave', - action__search: 'Pesquisar chaves', + action__add: 'Adicionar nova chave de API', + action__search: 'Pesquisar chaves de API', @@ - menuAction__revoke: 'Revogar chave', + menuAction__revoke: 'Revogar chave de API',Also applies to: 65-66
15-16
: Optional: add a parity check between en-US and pt-BR keysNo tests were added. Consider adding a lightweight check to ensure pt-BR keys stay in sync with en-US (e.g., a script that compares key paths or a TS-level “satisfies” check in CI). I can help draft this if you want.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/localizations/src/pt-BR.ts
(17 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}
: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/localizations/src/pt-BR.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/pt-BR.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/pt-BR.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/localizations/src/pt-BR.ts
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}
: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidany
type - preferunknown
when type is uncertain, then narrow with type guards
Useinterface
for object shapes that might be extended
Usetype
for unions, primitives, and computed types
Preferreadonly
properties for immutable data structures
Useprivate
for internal implementation details
Useprotected
for inheritance hierarchies
Usepublic
explicitly for clarity in public APIs
Preferreadonly
for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertions
for literal types:as const
Usesatisfies
operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noany
types without justification
Proper error handling with typed errors
Consistent use ofreadonly
for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/localizations/src/pt-BR.ts
packages/localizations/**/*
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Localization files must be placed in 'packages/localizations/'.
Files:
packages/localizations/src/pt-BR.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/localizations/src/pt-BR.ts
**/*
⚙️ CodeRabbit Configuration File
If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.
Files:
packages/localizations/src/pt-BR.ts
**/localizations/**/*.ts
⚙️ CodeRabbit Configuration File
**/localizations/**/*.ts
: Review the changes to localization files with the following guidelines:
- Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
- Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
- Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
- Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
- Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
- Ensure that all keys are unique and that there are no duplicate or conflicting entries.
- If you notice missing translations for new keys, flag them for completion.
Files:
packages/localizations/src/pt-BR.ts
🪛 Biome (2.1.2)
packages/localizations/src/pt-BR.ts
[error] 59-59: Expected a property, a shorthand property, a getter, a setter, or a method but instead found '-'.
Expected a property, a shorthand property, a getter, a setter, or a method here.
(parse)
[error] 60-60: expected ,
but instead found :
Remove :
(parse)
[error] 60-60: Expected a property, a shorthand property, a getter, a setter, or a method but instead found '-'.
Expected a property, a shorthand property, a getter, a setter, or a method here.
(parse)
[error] 61-61: Expected a semicolon or an implicit semicolon after a statement, but found none
An explicit or implicit semicolon is expected here...
...Which is required to end this statement
(parse)
[error] 69-69: Expected a semicolon or an implicit semicolon after a statement, but found none
An explicit or implicit semicolon is expected here...
...Which is required to end this statement
(parse)
[error] 169-169: Expected a semicolon or an implicit semicolon after a statement, but found none
An explicit or implicit semicolon is expected here...
...Which is required to end this statement
(parse)
[error] 825-826: Expected a semicolon or an implicit semicolon after a statement, but found none
An explicit or implicit semicolon is expected here...
...Which is required to end this statement
(parse)
[error] 828-830: Expected a statement but instead found ',
subtitle: 'para continuar em {{applicationName}}',
subtitleCombined: 'para continuar em {{applicationName}}',
title: 'Criar sua conta',
titleCombined: 'Criar sua conta','.
Expected a statement here.
(parse)
[error] 830-830: Expected a statement but instead found ','.
Expected a statement here.
(parse)
[error] 830-832: Expected a statement but instead found ',
socialButtonsBlockButton: 'Continuar com {{provider|titleize}}',
socialButtonsBlockButtonManyInView: '{{provider|titleize}}',
unstable__errors:'.
Expected a statement here.
(parse)
[error] 833-833: Expected a semicolon or an implicit semicolon after a statement, but found none
An explicit or implicit semicolon is expected here...
...Which is required to end this statement
(parse)
[error] 1118-1119: Expected a statement but instead found ',
removeResource:'.
Expected a statement here.
(parse)
🔇 Additional comments (14)
packages/localizations/src/pt-BR.ts (14)
17-36
: New taskChooseOrganization group looks correct and consistentTranslations are clear and friendly. Key names and structure align with other sections.
69-71
: Revocation flow copy matches “chave de API” terminologyGood alignment with the rest of the file; avoids “chave secreta.”
81-83
: Badges: overdue labels read naturally in pt-BR“Vencido em … / Vencido” are appropriate and consistent.
166-175
: Subscription details added comprehensivelyAll labels are accurate and idiomatic.
179-181
: Plan switch and payment view strings look goodThe placeholders and unit wording are correct.
Also applies to: 185-185
204-204
: Alt phone code provider action is clear“Enviar código via SMS” is concise and correct.
283-284
: API Keys titles in org/user contexts are consistent“Chaves de API” is used uniformly across Organization and User profiles and navbar.
Also applies to: 405-406, 933-934, 1118-1120
724-724
: Sign-in combined subtitle reads naturally“Bem-vindo de volta! Por favor, faça login para continuar” is friendly and concise.
832-847
: Error messages are clear and correctly localizedShort, accurate, and consistent tone. Placeholders are intact.
863-864
: Enterprise connection domain error: good clarityMatches expected phrasing for enterprise domain conflicts.
884-884
: Web3 wallet missing extension message is accurateInstruction to install the extension is clear.
1221-1225
: Passkeys section CTA is correct“Adicionar chave de acesso” matches terminology elsewhere.
106-107
: Translation Verified
The Portuguese string forcannotSubscribeUnrecoverable
accurately reflects the original English text (“Your existing subscription is more expensive than this plan.”). No changes are needed.
824-825
: No action required: pt-BR matches en-US for socialButtonsBlockButtonManyInView
The Brazilian Portuguese entry (packages/localizations/src/pt-BR.ts
line 824) uses{{provider|titleize}}
, which is identical to the en-US base string (packages/localizations/src/en-US.ts
line 807). Consistency confirmed.
pt-BR
translations
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
Co-authored-by: Tom Milewski <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
Adds missing ptBR translations that are available in the enUS translation file.
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit